Add context menu for multi-file entries (#12567) #13726

w0nderfu11 · 2025-08-20T10:28:57Z

Extend the Entry Editor context menu to handle entries with multiple linked files. This improves UX when managing more than one file per entry and aligns behavior across single- and multi-file scenarios.

Changes:

Made general actions in StandardActions enum for multi-file items
Extract selection predicates into SelectionChecks and reuse for actions
Introduce SingleSelectionMenuBuilder and MultiSelectionMenuBuilder (pattern strategy fix)
Extend ContextMenuFactory to delegate to builder based on selection
Refactor ContextAction: unified enablement by bindings
Remove CopyMultipleFilesAction and merged into CopySingleFileAction
Wire LinkedFilesEditor to new ContextMenuFactory; keep double-click behavior
Update localization: add pluralized keys, remove obsolete ones; localization tests pass
Add/update unit tests: ContextActionTest, ContextMenuFactoryTest, SingleSelectionMenuBuilderTest,
MultiSelectionMenuBuilderTest, SelectionChecksTest
Guard LinkedFileViewModel to avoid a JavaFX crash

Fixes #12567
Keywords: context menu, linked files, multi-selection, UI

Steps to test

Mandatory checks

I own the copyright of the code submitted and I license it under the MIT license
Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (if change is visible to the user)
Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
Checked documentation (developer & user docs): information is available and up to date. If not, I created an issue at https://github.com/JabRef/user-documentation/issues/ (or submitted a PR)

Extend the Entry Editor context menu to handle entries with multiple linked files. This improves UX when managing more than one file per entry and aligns behavior across single- and multi-file scenarios. Changes: - Add plural actions to StandardActions enum - Rewrite ContextAction.execute() for multi-file cases - Extend ContextMenuFactory to build multi-file items - Rework MultiContextAction to operate on selections - Introduce CopyMultipleFilesAction (new class) - Update/add localization keys; tests pass - Add unit tests: ContextActionTest, ContextMenuFactoryTest, MultiContextActionTest, CopyMultipleFilesActionTest - Guard LinkedFileViewModel to avoid a JavaFX crash Fixes JabRef#12567 Keywords: context menu, linked files, multi-selection, UI

jabgui/src/main/java/org/jabref/gui/copyfiles/CopyMultipleFilesAction.java

jabgui/src/test/java/org/jabref/gui/fieldeditors/contextmenu/MultiContextActionTest.java

…enuFactory

…gful check

w0nderfu11 · 2025-08-20T13:56:17Z

i set up checkstyle with your guide but it doesn`t show me some problems in test classes, only in main module)

jabgui/src/main/java/org/jabref/gui/copyfiles/CopyMultipleFilesAction.java

jabgui/src/main/java/org/jabref/gui/fieldeditors/contextmenu/MultiContextAction.java

w0nderfu11 · 2025-08-20T15:19:09Z

Hi @koppor, all checks have passed ✅ Could you please review and approve when you have time?
Thanks a lot!

subhramit · 2025-08-20T17:17:15Z

i set up checkstyle with your guide but it doesn`t show me some problems in test classes, only in main module)

Check this setting on the right (screenshot taken from here)

w0nderfu11 · 2025-08-20T17:34:06Z

i set up checkstyle with your guide but it doesn`t show me some problems in test classes, only in main module)

Check this setting on the right (screenshot taken from [here](https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace/intellij-13-code-style.html#put-jabrefs-checkstyle-configuration-in-place))

thank you anyway, but all check are done succesefully, so i wait for review

jabgui/src/main/java/org/jabref/gui/fieldeditors/contextmenu/MultiContextAction.java

calixtus

Thanks for your PR so far.
Some remarks made.

I noticed the Strategy Pattern was somewhat broken there (not by you). Please fix it.

jabgui/src/main/java/org/jabref/gui/actions/StandardActions.java

jabgui/src/main/java/org/jabref/gui/copyfiles/CopyMultipleFilesAction.java

jabgui/src/main/java/org/jabref/gui/fieldeditors/LinkedFileViewModel.java

jabgui/src/main/java/org/jabref/gui/fieldeditors/contextmenu/MultiContextAction.java

jabgui/src/test/java/org/jabref/gui/copyfiles/CopyMultipleFilesActionTest.java

jabgui/src/test/java/org/jabref/gui/fieldeditors/contextmenu/ContextMenuFactoryTest.java

calixtus · 2025-08-22T10:30:09Z

I mean reuse existing commands with changed text: eg 'Download file(s)'

w0nderfu11 · 2025-08-22T12:16:02Z

Thx for your feedback, i will research the problems you marked and try to solve, if it`s possible, thx a lot

…sActionTest.java Co-authored-by: Carl Christian Snethlage <[email protected]>

…menu - Introduce ContextMenuBuilder + SingleSelectionMenuBuilder + MultiSelectionMenuBuilder - Extract shared checks/openContainingFolders into SelectionChecks - ContextMenuFactory delegates to strategies; no more branching by selection size - LinkedFilesEditor initializes ContextMenuFactory once and just requests menus on right-click - Replace plural menu commands with single StandardActions; multi-selection handled inside builders - Fix NPE in ContextAction executable binding by removing null observables and binding menu disable state properly - Remove obsolete MultiContextAction and its tests Follow-ups: - Convert hardcoded labels to i18n keys (Download file(s), Open folder(s), etc.) - Consider removing *_FILES actions from enum if unused elsewhere - Re-add unit tests around builders/factory (TestFX/JUnit5) once API stabilized

w0nderfu11 · 2025-09-02T09:22:47Z

Thanks for your PR so far. Some remarks made.

I noticed the Strategy Pattern was somewhat broken there (not by you). Please fix it.

ContextMenuFactory now delegates to ContextMenuBuilder strategies (SingleSelectionMenuBuilder / MultiSelectionMenuBuilder) with shared checks in SelectionChecks.

w0nderfu11 · 2025-09-02T14:57:50Z

All the review has been done, i will test it manually and do unit test, after make a PR if all is OK

calixtus · 2025-10-03T14:39:50Z

Hi, i think the next iteration will probably be the last one. I just made some quick refactorings to ContextMenuFactoryTest to make it a bit more readable. It was just like a wall that hit me will all the declarations in the single tests.

Please apply the suggested changes. After that, we will finish this PR and get it merged. Most is already good and you did a great job in this PR.

w0nderfu11 · 2025-10-06T09:09:29Z

Hi, @calixtus let`s make a summary and i will start work - so i fix thing above, and as @koppor said, split logic to package logic, right?

calixtus · 2025-10-06T19:11:11Z

yes

w0nderfu11 · 2025-10-08T11:28:01Z

@koppor @calixtus @subhramit about merging to package ...logic. Would you mind if i create package in org,jabref.logic ---> or.jabref.logic.files

Other way - i found LinkedFileHandler in package org.jabref.logic.externalfiles

Or i even can make in this package additional file as LinkedFileCopier, for example

What do you prefer? I will do LinkedFileCopier in externalfiles package for now, after your answer we will see

calixtus · 2025-10-08T12:07:33Z

Hey, we briefly talked about the refactoring, @koppor suggested. We think we should do this in a follow-up. So forget about moving stuff to logic and just polish this one. Then we finalize and merge.

Siedlerchr · 2025-10-08T14:56:25Z

don't forget the openrewrite test

w0nderfu11 · 2025-10-08T15:22:10Z

don't forget the openrewrite test

Yes, sure, i will check submodules, do rewrite and changelog, ty for notifying

w0nderfu11 · 2025-10-08T15:35:48Z

What i did:

1.ContextMenuFactory - added jspecify NonNull and deleted static import, using Object now (Objects.requireNonNull(selection, "...")

MultiSelectionMenuBuilder - merged all methods from SelectionChecks(it was deleted for non profit abstraction) and updated test class also. Function Copy to folder now allMatch (was anyMatch), so it available only for downloaded local files (if they are selected and exist)
LinkedFilesEditor - returned old switch
in CopyLinkedFilesAction - changed ErrorDialog to notification interface (was not split logic and gui as we discussed)

Now i will run all tests, test it in application finally and do commit soon!

calixtus · 2025-10-10T16:33:42Z

You may have forgotten to push your commit.

w0nderfu11 · 2025-10-10T16:42:13Z

You may have forgotten to push your commit.

No-no, I`m sick now (ill), no energy for coding now, i will polish it soon do not worry

calixtus · 2025-10-10T16:47:05Z

Oh ok, sorry. Get well soon!
No hurry.

w0nderfu11 · 2025-10-13T13:21:17Z

@calixtus @subhramit i have a problem

Gradle tries to find snapshot version but there is no one here)
I already reseted this file from my remote branch, tried from upstream but it`s not fixing

I mean i can just change version but i dont really wana push this file. Do you know whats the problem?

What went wrong:
Could not determine the dependencies of task ':jabgui:test'.

Could not resolve all dependencies for configuration ':jabgui:testRuntimeClasspath'.
Could not find io.github.adr:e-adr:2.0.0-SNAPSHOT.
Searched in the following locations:
- https://repo.maven.apache.org/maven2/io/github/adr/e-adr/2.0.0-SNAPSHOT/maven-metadata.xml
- https://repo.maven.apache.org/maven2/io/github/adr/e-adr/2.0.0-SNAPSHOT/e-adr-2.0.0-SNAPSHOT.pom
- https://oss.sonatype.org/content/repositories/snapshots/io/github/adr/e-adr/2.0.0-SNAPSHOT/maven-metadata.xml
- https://oss.sonatype.org/content/repositories/snapshots/io/github/adr/e-adr/2.0.0-SNAPSHOT/e-adr-2.0.0-SNAPSHOT.pom
- https://jitpack.io/io/github/adr/e-adr/2.0.0-SNAPSHOT/maven-metadata.xml
- https://jitpack.io/io/github/adr/e-adr/2.0.0-SNAPSHOT/e-adr-2.0.0-SNAPSHOT.pom
- https://oss.sonatype.org/content/groups/public/io/github/adr/e-adr/2.0.0-SNAPSHOT/maven-metadata.xml
- https://oss.sonatype.org/content/groups/public/io/github/adr/e-adr/2.0.0-SNAPSHOT/e-adr-2.0.0-SNAPSHOT.pom
- https://maven-central.storage-download.googleapis.com/repos/central/data/io/github/adr/e-adr/2.0.0-SNAPSHOT/maven-metadata.xml
- https://maven-central.storage-download.googleapis.com/repos/central/data/io/github/adr/e-adr/2.0.0-SNAPSHOT/e-adr-2.0.0-SNAPSHOT.pom
- https://sandec.jfrog.io/artifactory/repo/io/github/adr/e-adr/2.0.0-SNAPSHOT/maven-metadata.xml
- https://sandec.jfrog.io/artifactory/repo/io/github/adr/e-adr/2.0.0-SNAPSHOT/e-adr-2.0.0-SNAPSHOT.pom
- file:/C:/Users/Vitaliy/jabref/jablib/lib/io/github/adr/e-adr/2.0.0-SNAPSHOT/maven-metadata.xml
- file:/C:/Users/Vitaliy/jabref/jablib/lib/io/github/adr/e-adr/2.0.0-SNAPSHOT/e-adr-2.0.0-SNAPSHOT.pom
Required by:
project ':jabgui'
project ':jabgui' > project :jablib
Could not find io.github.adr:e-adr:2.0.0-SNAPSHOT.
Searched in the following locations:
- https://repo.maven.apache.org/maven2/io/github/adr/e-adr/2.0.0-SNAPSHOT/maven-metadata.xml
- https://repo.maven.apache.org/maven2/io/github/adr/e-adr/2.0.0-SNAPSHOT/e-adr-2.0.0-SNAPSHOT.pom
- https://oss.sonatype.org/content/repositories/snapshots/io/github/adr/e-adr/2.0.0-SNAPSHOT/maven-metadata.xml
- https://oss.sonatype.org/content/repositories/snapshots/io/github/adr/e-adr/2.0.0-SNAPSHOT/e-adr-2.0.0-SNAPSHOT.pom
- https://jitpack.io/io/github/adr/e-adr/2.0.0-SNAPSHOT/maven-metadata.xml
- https://jitpack.io/io/github/adr/e-adr/2.0.0-SNAPSHOT/e-adr-2.0.0-SNAPSHOT.pom
- https://oss.sonatype.org/content/groups/public/io/github/adr/e-adr/2.0.0-SNAPSHOT/maven-metadata.xml
- https://oss.sonatype.org/content/groups/public/io/github/adr/e-adr/2.0.0-SNAPSHOT/e-adr-2.0.0-SNAPSHOT.pom
- https://maven-central.storage-download.googleapis.com/repos/central/data/io/github/adr/e-adr/2.0.0-SNAPSHOT/maven-metadata.xml
- https://maven-central.storage-download.googleapis.com/repos/central/data/io/github/adr/e-adr/2.0.0-SNAPSHOT/e-adr-2.0.0-SNAPSHOT.pom
- https://sandec.jfrog.io/artifactory/repo/io/github/adr/e-adr/2.0.0-SNAPSHOT/maven-metadata.xml
- https://sandec.jfrog.io/artifactory/repo/io/github/adr/e-adr/2.0.0-SNAPSHOT/e-adr-2.0.0-SNAPSHOT.pom
- file:/C:/Users/Vitaliy/jabref/jablib/lib/io/github/adr/e-adr/2.0.0-SNAPSHOT/maven-metadata.xml
- file:/C:/Users/Vitaliy/jabref/jablib/lib/io/github/adr/e-adr/2.0.0-SNAPSHOT/e-adr-2.0.0-SNAPSHOT.pom
Required by:
project ':jabgui' > project :versions

Siedlerchr · 2025-10-13T13:23:49Z

You need to merge in the latest main, then it will be resolved

w0nderfu11 · 2025-10-13T14:19:15Z

@calixtus Done

calixtus

Looks good to me!

.

calixtus · 2025-10-13T19:03:20Z

Hooray!

w0nderfu11 added 2 commits August 20, 2025 13:18

Apply OpenRewrite recipes

5c3fc14

trag-bot bot reviewed Aug 20, 2025

View reviewed changes

jabgui/src/main/java/org/jabref/gui/copyfiles/CopyMultipleFilesAction.java Outdated Show resolved Hide resolved

Fixed test and optimized imports

740cc4a

trag-bot bot reviewed Aug 20, 2025

View reviewed changes

jabgui/src/test/java/org/jabref/gui/fieldeditors/contextmenu/MultiContextActionTest.java Outdated Show resolved Hide resolved

trag-bot bot reviewed Aug 20, 2025

View reviewed changes

jabgui/src/test/java/org/jabref/gui/fieldeditors/contextmenu/MultiContextActionTest.java Outdated Show resolved Hide resolved

w0nderfu11 added 4 commits August 20, 2025 15:39

merge for problems with lib

afa12f1

fixed library and space in catch block

02797f7

Runned rewrite, fixed catch block and optimize logic of test ContextM…

8924487

…enuFactory

Fix tests: initialize JavaFX toolkit; replace empty catch with meanin…

f3f91e7

…gful check

Fix tests: added space after {

e6ef784

w0nderfu11 marked this pull request as ready for review August 20, 2025 14:08

trag-bot bot reviewed Aug 20, 2025

View reviewed changes

jabgui/src/main/java/org/jabref/gui/copyfiles/CopyMultipleFilesAction.java Outdated Show resolved Hide resolved

trag-bot bot reviewed Aug 20, 2025

View reviewed changes

jabgui/src/main/java/org/jabref/gui/copyfiles/CopyMultipleFilesAction.java Outdated Show resolved Hide resolved

trag-bot bot reviewed Aug 20, 2025

View reviewed changes

jabgui/src/main/java/org/jabref/gui/fieldeditors/contextmenu/MultiContextAction.java Outdated Show resolved Hide resolved

w0nderfu11 added 2 commits August 20, 2025 18:02

Trigger CI

f31fd86

Trigger CI

650bd9e

calixtus added the component: entry-editor label Aug 20, 2025

calixtus reviewed Aug 22, 2025

View reviewed changes

jabgui/src/main/java/org/jabref/gui/fieldeditors/contextmenu/MultiContextAction.java Outdated Show resolved Hide resolved

calixtus requested changes Aug 22, 2025

View reviewed changes

w0nderfu11 and others added 2 commits September 1, 2025 16:50

Update jabgui/src/test/java/org/jabref/gui/copyfiles/CopyMultipleFile…

8d86798

…sActionTest.java Co-authored-by: Carl Christian Snethlage <[email protected]>

Refactored ContextMenuFactoryTest for readability

730ddd3

w0nderfu11 marked this pull request as draft October 8, 2025 11:28

w0nderfu11 added 3 commits October 13, 2025 16:30

Merge branch 'main' into feat/multi-file-context-menu

b8f0625

Added fixes, deleted SelectionChecks

7f8116f

changelog fixed and localization

99e7745

w0nderfu11 marked this pull request as ready for review October 13, 2025 14:19

w0nderfu11 requested a review from subhramit October 13, 2025 14:19

calixtus approved these changes Oct 13, 2025

View reviewed changes

calixtus added this pull request to the merge queue Oct 13, 2025

Merged via the queue into JabRef:main with commit a9b50c6 Oct 13, 2025
71 of 79 checks passed

github-actions bot mentioned this pull request Oct 13, 2025

Have the context menu of linked files working for multipe selected files. #12567

Closed

w0nderfu11 deleted the feat/multi-file-context-menu branch October 14, 2025 08:05

Uh oh!

Add context menu for multi-file entries (#12567) #13726

Add context menu for multi-file entries (#12567) #13726

Uh oh!

Conversation

w0nderfu11 commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Steps to test

Mandatory checks

Uh oh!

Uh oh!

Uh oh!

Uh oh!

w0nderfu11 commented Aug 20, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

w0nderfu11 commented Aug 20, 2025

Uh oh!

subhramit commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

w0nderfu11 commented Aug 20, 2025

Uh oh!

Uh oh!

calixtus left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

calixtus commented Aug 22, 2025

Uh oh!

w0nderfu11 commented Aug 22, 2025

Uh oh!

w0nderfu11 commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

w0nderfu11 commented Sep 2, 2025

Uh oh!

calixtus commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

w0nderfu11 commented Oct 6, 2025

Uh oh!

calixtus commented Oct 6, 2025

Uh oh!

w0nderfu11 commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

calixtus commented Oct 8, 2025

Uh oh!

Siedlerchr commented Oct 8, 2025

Uh oh!

w0nderfu11 commented Oct 8, 2025

Uh oh!

w0nderfu11 commented Oct 8, 2025

Uh oh!

calixtus commented Oct 10, 2025

Uh oh!

w0nderfu11 commented Oct 10, 2025

Uh oh!

calixtus commented Oct 10, 2025

Uh oh!

w0nderfu11 commented Oct 13, 2025

Uh oh!

Siedlerchr commented Oct 13, 2025

Uh oh!

w0nderfu11 commented Oct 13, 2025

Uh oh!

calixtus left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

w0nderfu11 commented Aug 20, 2025 •

edited

Loading

subhramit commented Aug 20, 2025 •

edited

Loading

w0nderfu11 commented Sep 2, 2025 •

edited

Loading

calixtus commented Oct 3, 2025 •

edited

Loading

w0nderfu11 commented Oct 8, 2025 •

edited

Loading